update sql regexp to default to empty string when field is null #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe changes involve modifications to the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
qedi-r
changed the title
2 tasks
MatissJanis
requested changes
Sep 22, 2024
Comment on lines
30
to
41
| // @ts-expect-error Property 'number' does not exist on type 'unknown' | ||
| expect(rows[0].number).toBe(4); | ||
| expect((rows[0] as NumberRowType).number).toBe(4); |
There was a problem hiding this comment.
🔨 warning: manual type coercions hide the type issue rather than address it. Furthermore: they can and do often lead to subtle, hard-to-catch bugs.
If we cannot patch this properly (i.e. by explicitly stating the runQuery return type), then the previous solution of using @ts-expect-error is actually better.
There was a problem hiding this comment.
Oh. I disagree that expect-error is better, adding linter exceptions creates a culture of accepting the problem, instead of fixing it at the level you are able, as well as having other issues. But, I also understand it's not my call, and code consistency matters, so I'll revert those changes.
MatissJanis
reviewed
Sep 22, 2024
| @@ -27,7 +28,7 @@ describe('Web sqlite', () => { | |||
|
|
|||
| let rows = runQuery(db, 'SELECT * FROM numbers', null, true); | |||
| expect(rows.length).toBe(1); | |||
| // @ts-expect-error Property 'number' does not exist on type 'unknown' | |||
| //@ts-expect-error: Property 'number' does not exist on type 'unknown' | |||
There was a problem hiding this comment.
🥜 nitpick: would you mind undoing also these changes? Ideally the fingerprint of a PR should be as small as possible. And these comment changes are quite unnecessary. Thanks!
Suggested change
| //@ts-expect-error: Property 'number' does not exist on type 'unknown' | |
| // @ts-expect-error Property 'number' does not exist on type 'unknown' |
There was a problem hiding this comment.
Oh, shoot, yep. Sorry.
a-gradina
pushed a commit
to a-gradina/actual
that referenced
this pull request
Sep 24, 2024
matt-fidd
added a commit
that referenced
this pull request
Oct 3, 2024
* marked files for translation * added release note * fixed linting warnings * 🐛 fix account filters being overridden (#3441) *Reduce package size (#3443) * reduce package size of all packages * release notes * Update beforePackHook.ts * [Maintenance] Cleanup react aria packages and dedupe (#3450) * Cleanup react aria packages and dedupe * Release notes * ♻️ (synced-prefs) moving the prefs from metadata.json to the db (#3423) *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3479
Note that:
RegExp('null').test(null) ? 1 : 0;resolves to 1 in JS. 😢