-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voltage limit #224
Voltage limit #224
Conversation
I think keeping the battery at a certain Voltage (usually after 4 Volts degradation starts, and 3.7 is recommended for long life) is a good idea. I would definitely like to see this feature in the program. Another question is how well it works, have you tested it? |
I use A more user friendly approach would be to integrate this into the daemon so no login item has to be created for autostart manually. |
I'm not quite sure what to do with the file. Could you please tell me in detail what you need to do step by step to use the voltage limitation? |
Got it. I set battery voltage 11.1 11.4. This kept the battery within 60-72%. I like it:) |
This is a very cool idea @rguca! Could I ask you to edit it so that the
This would make your work compatible for all users in the same was as the current commands are. |
I also suggest adding a second optional argument to the For my use case it would be then: and for @djbob2000 it would be: Specifying a range like that would probably be better for the charging circuit, because it doesn't have to switch on and off as often. |
The syntax is now: Also optional with hysteresis: I tried to make the changes as close as possible to your request @actuallymentor |
This is an extremely cool PR @rguca, I've merged it. Please keep a close eye on the issue tab the coming weeks just in case this accidentally broke anything! |
Parts of this pull request got apparently rewritten in a subsequent merge, resulting in this feature not working in https://github.com/actuallymentor/battery/releases/tag/v1.2.2 |
Ah dammit. The merge conflicts must have bit me... @rguca could I ask you for a new PR with a fix for the broken merge? |
This is a draft for the feature request in #214.
Output: