-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General bugfixes #253
General bugfixes #253
Conversation
… debug, better logging, etc. Will revert some of it.
Apply accuracy-fix changes to bugfixes
@thdrmrphy thanks a lot for the efforts in improving the app. However the change in #244 broke one of the main features of the app, the ability to disable the charge limit and charge the battery to 100% (from the UI). Because when you disable it, This PR is likely fixing this part, but I'm not convinced that I'd consider a new method if the same sort of logic (disabling discharge and maintaining the state) is needed at multiple locations. What should not happen, however is that the primary function of the app (limit the charge and allow to toggle the limit from the UI) breaks. |
Is there anything I can contribute to this MR? |
Hey @jkellerer thanks for taking a look at this. It's been a bit since I really took a look at this code so forgive me if I'm missing something. I do think this PR fixes that issue (I'm not convinced the issue was caused by #244 but I don't think I helped it by adding the extra logic) and from what I remember, Also, I have no idea why I put Having said all that there's a good chance I'm missing something and whilst I haven't had the issue you're describing with the UI ("it works on my machine") the app currently needs a lot of reworking and this PR is definitely not ready to merge. @Chr1s70ph thank you so much for the help, to anyone wanting to contribute I think the next steps that we can take here are probably to identify and document the issues that @jkellerer mentioned (as well as any others that pop up) including the relevant logs from the app and then we can try to find out where it's going wrong. Also, error handling (or lack thereof) and variable validation are major issues here so if perhaps we can try to implement checks at every possible point (so that we don't keep getting issues where the app is trying to work out whether a string or a numerical value is higher). From memory there might be some other open PRs to help with this. I'll keep an eye on this and try to contribute where I can but thanks for the input everyone and I hope this gets us somewhere more stable. |
closes #210 |
This PR:
disable_discharging
woulddisable_charging
, even when called from withinenable_charging
I'm very much open to suggestions. This PR kind of throws everything at trying to fix bugs and so may have made some things a bit messier than they used to be. Having said that, I've been stress-testing this code daily for a while and I've not run into the original issues any longer.
Hope it helps!