Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a
digitalPinToPort
macro usage missing in softspi fastio implementation for Teensy, that worked by accident, only because Teensy implementation of this macro is trivial:#define digitalPinToPort(pin) (pin)
. After that Teensy fastio implementation becomes pretty cross platform, so I enabled STM32 as a consumer of it.Also did some
PORTreg_t
cleanup, because comments were contradicting the code, but I don't have hardware to test it on different platforms.I mean this comment specifically:
Here it was not consistent with the code, but here it was, so I'm not sure if this fix is correct, but it seemd odd that direction register would be different size than access register.