Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Siemens Simatic IOT2050 Basic/Advanced #618

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

schnurma
Copy link
Contributor

Hello,
I added support for GPIO, AIO, I2C, SPI, UART, PWM, NeoPixels for the Siemens Simatic IOT2050 SBC

I added my MIT Licence Informations to the Files I heavily modified and for files with only few changes I extend the licence informatons -> am65xx/pin.py ; am65xx/pwmout.py.

thanks
best regards
Martin Schnur

Added support for GPIO, AIO, I2C, SPI, UART, PWM, NeoPixels
Added pylint comments to /am65xx/pin.py and pwmout.py. Which are minor "issues" which should be totaly ok to pass.
@schnurma
Copy link
Contributor Author

Checks failed because of missing Value. After the Pull-Request #249 is accepted this should work.

Error Message:
File "/home/runner/work/Adafruit_Blinka/Adafruit_Blinka/src/board.py", line 280, in
elif board_id == ap_board.SIEMENS_SIMATIC_IOT2050_ADV:
AttributeError: module 'adafruit_platformdetect.constants.boards' has no attribute 'SIEMENS_SIMATIC_IOT2050_ADV'

Error: Process completed with exit code 2.

@makermelissa
Copy link
Contributor

Yeah, adafruit/Adafruit_Python_PlatformDetect#249 will need to be merged in first and a new platform detect release needs to be published, then I'll re-run the checks on this PR and it should pass. I'll let you know if there's anything that needs to be done on your end. :)

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great. You even fixed a typo in busio. :)

@makermelissa makermelissa merged commit 0df67f7 into adafruit:main Sep 22, 2022
@schnurma
Copy link
Contributor Author

Thanks for your fast response.
Tested it today, everything seems fine :)

best regards
Martin Schnur

@makermelissa
Copy link
Contributor

Thank you for adding. It was done very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants