Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support longer ms values in ms2tick #706

Merged
merged 1 commit into from
Dec 9, 2021
Merged

support longer ms values in ms2tick #706

merged 1 commit into from
Dec 9, 2021

Conversation

thinkOfaNumber
Copy link
Contributor

Use uint64_t for intermediate calculate of pdMS_TO_TICKS so stop integer overflow for long ms values. Fixes #705

hathach
hathach approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, look good, CI failed randomly, re-run and will merged when passed.

@thinkOfaNumber
Copy link
Contributor Author

CI failed randomly, re-run and will merged when passed.

Thanks I saw the 503 but couldn't re-run it so I guessed I didn't have the privileges. Thanks for following it up!

@hathach hathach merged commit b8e2b61 into adafruit:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SoftwareTimer/ms2tick overflow
2 participants
@thinkOfaNumber @hathach