Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Datanoise PicoADK v2. #1487

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Datanoise PicoADK v2. #1487

wants to merge 4 commits into from

Conversation

DatanoiseTV
Copy link

No description provided.

DatanoiseTV
DatanoiseTV commented Oct 8, 2024
View reviewed changes
Copy link
Author

@DatanoiseTV DatanoiseTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove wrong features, fix typos and name.

tannewt
tannewt requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add images too.

@DatanoiseTV
Copy link
Author

Please add images too.
Thank you for the hint. Done.

@tannewt
Copy link
Member

tannewt commented Oct 10, 2024

The images are the wrong dimensions: https://github.com/adafruit/circuitpython-org/actions/runs/11271484404/job/31344389534?pr=1487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DatanoiseTV @tannewt