Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MH 2.13.3 does not work with TB 52.9.1 #526

Closed
lashkevi opened this issue Sep 27, 2018 · 4 comments
Closed

MH 2.13.3 does not work with TB 52.9.1 #526

lashkevi opened this issue Sep 27, 2018 · 4 comments

Comments

@lashkevi
Copy link

Markdown Here 2.13.3 does not work at al with TB 52.9.1 (Linux OpenSUSE). No "Toggle Markdown" button, no reaction to Ctrl+Alt+M, no Options in Tools menu.
@morsedl
Copy link

morsedl commented Sep 28, 2018

+1

I use TB 45.8.0 (Ubuntu 16.04 LTS), because I rely heavily not only on Markdown Here, but also Muttator (which unfortunately they do not updated that often).

Once TB auto-updated from Markdown Here 2.13.2 to 2.13.3, pretty much everything stopped working, as described well by the OP, @lashkevi.

adam-p added a commit that referenced this issue Sep 30, 2018
@adam-p
Fix #524 and #526: Broken in non-English Thunderbird
54fb24b 
A string added in the Firefox 60 fix wasn't copied to the non-English `messages.json` files, which meant that it wasn't in the non-English `strings.properties` and `string.dtd` files. This caused Thunderbird to not load the overlay in Thunderbird, which prevented it from being present in the message window.

To help mitigate this in the future, to some degree, the `i18n.js` script makes sure that all English strings are present in the other languages when creating the the .properties and .dtd files. But I still have to remember to run that script.
@adam-p
Copy link
Owner

adam-p commented Sep 30, 2018 •
edited
Loading

See also #524. Fix is in the works.

adam-p added a commit that referenced this issue Sep 30, 2018
@adam-p
Merge pull request #527 from adam-p/fix-tbird-intl
1df5aee 
Fix #524 and #526: Broken in non-English Thunderbird
@adam-p
Copy link
Owner

adam-p commented Sep 30, 2018

Fixed by PR #527, in v2.13.4. Currently in Mozilla review queue (position 18 of 18).

@adam-p adam-p closed this as completed Sep 30, 2018
@adam-p
Copy link
Owner

adam-p commented Sep 30, 2018

Mozilla approved the new version just now. You should get the update automatically, or you can down it from here: https://addons.thunderbird.net/en-US/thunderbird/addon/markdown-here-xul/versions/

NyanKiyoshi pushed a commit to NyanKiyoshi/markdown-here that referenced this issue Feb 27, 2020
@adam-p
Fix adam-p#524 and adam-p#526: Broken in non-English Thunderbird
3243bf9 
A string added in the Firefox 60 fix wasn't copied to the non-English `messages.json` files, which meant that it wasn't in the non-English `strings.properties` and `string.dtd` files. This caused Thunderbird to not load the overlay in Thunderbird, which prevented it from being present in the message window.

To help mitigate this in the future, to some degree, the `i18n.js` script makes sure that all English strings are present in the other languages when creating the the .properties and .dtd files. But I still have to remember to run that script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adam-p @morsedl @lashkevi