Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint from 3.x to 4.x #196

Closed
soda0289 opened this issue Apr 10, 2017 · 2 comments
Closed

Update ESLint from 3.x to 4.x #196

soda0289 opened this issue Apr 10, 2017 · 2 comments

Comments

@soda0289
Copy link
Contributor

Currently gulp-eslint package.json only installs eslint v3. With the soon to be released eslint v4 it would be nice if gulp-eslint could be upgraded as well. Do we need to have eslint as dependency? Would a peer dependency work as well?
@shinnn
Copy link
Collaborator

shinnn commented Apr 10, 2017 •
edited
Loading

Do we need to have eslint as dependency?

Yes.

Would a peer dependency work as well?

No. #68 (comment)

@shinnn shinnn changed the title Add support for ESLint v4 Update ESLint from 3.x to 4.x Apr 10, 2017
@soda0289
Copy link
Contributor Author

soda0289 commented Apr 10, 2017 •
edited
Loading

@shinnn Is this sufficient #198

This was referenced Apr 10, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinnn @soda0289