Add support for ESLint v4 to package.json #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnn
requested changes
Apr 10, 2017
| @@ -41,7 +41,7 @@ | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "bufferstreams": "^1.1.1", | |||
| "eslint": "^3.0.0", | |||
| "eslint": "3.x.x - 4.x.x", | |||
There was a problem hiding this comment.
They have only released alpha build which means settings it to ^4.0.0 will not work. I can wait a few weeks until the official v4 is out. Thanks.
|
Will wait for official v4 to be released |
|
@soda0289 No need to close this. We can keep this open and will merge it when |
|
I screwed up by force pushing to this branch after closing it. Sorry, I'll have to open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #196