Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pydantic v2 backwards compatibility #26

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

adamkirchberger
Copy link
Owner

No description provided.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for nectl ready!

Name Link
🔨 Latest commit a7ecfe0
🔍 Latest deploy log https://app.netlify.com/sites/nectl/deploys/653fbea5f88f340008d1013d
😎 Deploy Preview https://deploy-preview-26--nectl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #26 (a7ecfe0) into main (e053c23) will increase coverage by 1.66%.
Report is 9 commits behind head on main.
The diff coverage is 88.11%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   92.35%   94.02%   +1.66%     
==========================================
  Files          19       20       +1     
  Lines         916      954      +38     
==========================================
+ Hits          846      897      +51     
+ Misses         70       57      -13     
Files Coverage Δ
nectl/__init__.py 100.00% <100.00%> (ø)
nectl/configs/drivers/__init__.py 100.00% <100.00%> (ø)
nectl/configs/render.py 98.70% <100.00%> (ø)
nectl/configs/utils.py 96.55% <100.00%> (+0.12%) ⬆️
nectl/datatree/cli.py 87.23% <100.00%> (ø)
nectl/datatree/facts_utils.py 69.00% <100.00%> (ø)
nectl/datatree/hosts.py 100.00% <100.00%> (ø)
nectl/nectl.py 100.00% <100.00%> (ø)
nectl/settings.py 96.49% <60.00%> (-3.51%) ⬇️
nectl/configs/cli.py 85.71% <69.69%> (+16.82%) ⬆️

@adamkirchberger adamkirchberger merged commit 7c16bc1 into main Oct 30, 2023
11 of 12 checks passed
@adamkirchberger adamkirchberger deleted the pydantic_v2_compat branch October 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant