Simplified version comparison

adamlui · Oct 18, 2024 · 19544f0 · 19544f0
1 parent 8a5a50f
commit 19544f0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/publish-to-amo-on-ff-bump.yml b/.github/workflows/publish-to-amo-on-ff-bump.yml
@@ -20,7 +20,7 @@ jobs:
         run: |
           CURRENT_VER=$(cat firefox/extension/manifest.json | grep '"version"' | sed -E 's/.*"version": "(.*)".*/\1/')
           PREV_VER=$(git show HEAD^:firefox/extension/manifest.json | grep '"version"' | sed -E 's/.*"version": "(.*)".*/\1/')
-          if [ "$(printf '%s\n' "$PREV_VER" "$CURRENT_VER" | sort -V | head -n 1)" != "$CURRENT_VER" ] ; then
+          if [ "$CURRENT_VER" != "$PREV_VER" ] ; then
                echo "Extension updated from $PREV_VER to $CURRENT_VER"
                echo "VERSION_CHANGED=true" >> $GITHUB_ENV
           else echo "VERSION_CHANGED=false" >> $GITHUB_ENV ; fi

diff --git a/.github/workflows/publish-to-cws-ews-on-chromium-bump.yml b/.github/workflows/publish-to-cws-ews-on-chromium-bump.yml
@@ -20,7 +20,7 @@ jobs:
         run: |
           CURRENT_VER=$(cat chromium/extension/manifest.json | grep '"version"' | sed -E 's/.*"version": "(.*)".*/\1/')
           PREV_VER=$(git show HEAD^:chromium/extension/manifest.json | grep '"version"' | sed -E 's/.*"version": "(.*)".*/\1/')
-          if [ "$(printf '%s\n' "$PREV_VER" "$CURRENT_VER" | sort -V | head -n 1)" != "$CURRENT_VER" ] ; then
+          if [ "$CURRENT_VER" != "$PREV_VER" ] ; then
                echo "Extension updated from $PREV_VER to $CURRENT_VER"
                echo "CURRENT_VER=${CURRENT_VER}" >> $GITHUB_ENV # for notes field in EWS step
                echo "VERSION_CHANGED=true" >> $GITHUB_ENV