Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading adapters with load_best_model_at_end in Trainer #122

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

calpt
Copy link
Member

@calpt calpt commented Feb 24, 2021

Adding --load_best_model_at_end currently fails when added to a training script as it tries to load a full model.

@calpt calpt requested a review from hSterz February 24, 2021 13:44
@calpt calpt force-pushed the fix/load_best_model_at_end branch from 51e4e53 to 5d789c7 Compare March 1, 2021 18:55
@calpt calpt force-pushed the fix/load_best_model_at_end branch from 5d789c7 to c04633e Compare March 1, 2021 19:03
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe a test for this might be usefull

@calpt calpt merged commit eeb7877 into adapter-hub:master Mar 2, 2021
@calpt calpt deleted the fix/load_best_model_at_end branch March 2, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants