Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings in model config & base model classes #304

Merged
merged 10 commits into from
Mar 23, 2022
Merged

Refactorings in model config & base model classes #304

merged 10 commits into from
Mar 23, 2022

Conversation

calpt
Copy link
Member

@calpt calpt commented Mar 14, 2022 •
edited
Loading

Depends on #292.

This PR includes the following changes:

  • Remove ModelConfigAdaptersMixin in model config classes. Instead, use a new wrap_config() method to modify configs for adapter usage.
  • Remove setting model_name in from_pretrained() method. Instead, set from recent name_or_path config attribute.
  • breaking: Remove support for passing custom_heads argument to from_pretrained() method of PretrainedConfig
  • breaking: Move transformers.__adapters_version__ to transformers.adapters.__version__

@calpt calpt changed the title Round 3 of Large Refactorings Round 3 of Refactorings Mar 15, 2022
@adapter-hub-bert
Copy link
Member

This PR/issue depends on:

Automatically provided by Dependent Issues (🤖).

@calpt calpt marked this pull request as ready for review March 17, 2022 14:58
@calpt calpt requested a review from hSterz March 17, 2022 14:58
@calpt calpt changed the title Round 3 of Refactorings Refactorings in model config & base model classes Mar 23, 2022
@hSterz hSterz merged commit 5893a89 into adapter-hub:develop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calpt @adapter-hub-bert @hSterz