Adding adapters support for GPT-J #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calpt
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Hey @ChiragBSavani, thank you very much for your contribution! This looks very good to me, just one tiny final comment: Please also add the GPT-J doc to the table of contents in the adapter_docs index.rst.
|
@calpt Thank you for looking into the PR. I have made changes according to your comment and also parallel I have fixed one issue which I found out meanwhile. The rest looks very good. Please have a look at it again when you have time. |
calpt
reviewed
Oct 13, 2022
calpt
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of adapters for GPT-J with tests and documentation.