Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix training T5 adapter models with Trainer #599

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix training T5 adapter models with Trainer #599

merged 1 commit into from
Nov 15, 2023

Conversation

calpt
Copy link
Member

@calpt calpt commented Nov 7, 2023

@calpt calpt added bug Something isn't working adapters-lib labels Nov 7, 2023
@calpt calpt marked this pull request as ready for review November 7, 2023 19:34
@calpt calpt changed the base branch from adapters to main November 14, 2023 20:54
TimoImhof
TimoImhof approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested both scripts again locally and they run ✅

@calpt calpt merged commit a6055d0 into adapter-hub:main Nov 15, 2023
6 checks passed
@calpt calpt deleted the fix/t5-trainer branch November 15, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof TimoImhof approved these changes

@lenglaender lenglaender Awaiting requested review from lenglaender

@hSterz hSterz Awaiting requested review from hSterz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @TimoImhof