Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mistral support #609

Merged
merged 10 commits into from
Jul 20, 2024
Merged

Add mistral support #609

merged 10 commits into from
Jul 20, 2024

Conversation

KorventennFR
Copy link
Contributor

This PR is the follow up to #605 , adding adapter support for MistralAI's Mistral model.
It should fix the previous failed tests.

Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall, just one minor comment. Please also make sure to pass the style checks before we can merge it.

Thanks a lot for your work on this!

tests/test_mistral.py Outdated Show resolved Hide resolved
@KorventennFR
Copy link
Contributor Author

Thank you for taking the time to review this. I had to code on a windows machine where I couldn't use or install Make but I will be able to do that very soon. I also noticed an unexpected behavior when doing inference after loading Mistral models with the adapters library. I will look into that before pushing again.

@lenglaender
Copy link
Member

Hey @KorventennFR,
you mentioned that you have encountered some unexpected behaviour during inference. Have you investigated this further? Are you currently working on a fix or can you provide us a script with which we can reproduce this unexpected behaviour?
Thanks!

@calpt calpt merged commit 5cc7557 into adapter-hub:main Jul 20, 2024
4 checks passed
dainis-boumber added a commit to ReDASers/adapters that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants