-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mistral support #609
Add mistral support #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall, just one minor comment. Please also make sure to pass the style checks before we can merge it.
Thanks a lot for your work on this!
Thank you for taking the time to review this. I had to code on a windows machine where I couldn't use or install Make but I will be able to do that very soon. I also noticed an unexpected behavior when doing inference after loading Mistral models with the adapters library. I will look into that before pushing again. |
Hey @KorventennFR, |
This PR is the follow up to #605 , adding adapter support for MistralAI's Mistral model.
It should fix the previous failed tests.