Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipping composition blocks in not applicable layers #665

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix skipping composition blocks in not applicable layers #665

merged 1 commit into from
Apr 15, 2024

Conversation

calpt
Copy link
Member

@calpt calpt commented Mar 31, 2024 •
edited
Loading

Fixes #664.

Changes in this PR:

  • Avoid throwing NotImplementedError in an unsupported block if none if the child adapters are part of the respective layer.
  • Pass along "last" invoked adapter module name in LoRA & bottleneck states to make sure "last" is actually existing in the respective layer.

@calpt calpt marked this pull request as ready for review March 31, 2024 19:53
TimoImhof
TimoImhof approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing it!

@TimoImhof TimoImhof merged commit 2652d27 into adapter-hub:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof TimoImhof approved these changes

@hSterz hSterz Awaiting requested review from hSterz

@lenglaender lenglaender Awaiting requested review from lenglaender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding adapters and fusion layer to UNIPELT
2 participants
@calpt @TimoImhof