Add download redirect for AH adapters to HF #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoImhof
approved these changes
Jun 24, 2024
|
I added a parameter description in the modified functions. |
dainis-boumber
added a commit
to ReDASers/adapters
that referenced
this pull request
Aug 24, 2024
This PR implements an automatic redirect for `load_adapter()` from Hub repo adapters to the HF Hub: - If `source` is not specified, will automatically redirect attempts to load from Hub repo to HF Hub. Will also issue a warning to set new id explicitly. - if `source="ah"` explicitly, will still load from Hub repo link and issue a warning. Also updated docs accordingly & removed sections specific to Hub repo loading. --------- Co-authored-by: Timo Imhof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an automatic redirect for
load_adapter()from Hub repo adapters to the HF Hub:sourceis not specified, will automatically redirect attempts to load from Hub repo to HF Hub. Will also issue a warning to set new id explicitly.source="ah"explicitly, will still load from Hub repo link and issue a warning.Also updated docs accordingly & removed sections specific to Hub repo loading.