Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Information #75

Merged
merged 6 commits into from
Oct 27, 2020
Merged

Label Information #75

merged 6 commits into from
Oct 27, 2020

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented Oct 19, 2020

The label information is now saved with the head. For a model with a specific head where the head config is None it is saved as an additional parameter. For a model with multiple heads it is a parameter in the ehad config, so every head can have different labels.

@hSterz hSterz marked this pull request as ready for review October 19, 2020 09:29
@hSterz hSterz requested a review from calpt October 19, 2020 09:29
@calpt calpt self-assigned this Oct 19, 2020
@calpt calpt changed the title Lable Information Label Information Oct 19, 2020
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice overall! 👍 Just a few comments/ questions below.

src/transformers/adapter_bert.py Show resolved Hide resolved
src/transformers/adapter_bert.py Show resolved Hide resolved
src/transformers/adapter_config.py Outdated Show resolved Hide resolved
src/transformers/adapter_model_mixin.py Outdated Show resolved Hide resolved
@calpt calpt linked an issue Oct 19, 2020 that may be closed by this pull request
@calpt calpt self-requested a review October 27, 2020 08:49
@hSterz hSterz merged commit e070dc7 into adapter-hub:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label information to adapter
2 participants