Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XModelWithHeads in pipelines #80

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Support XModelWithHeads in pipelines #80

merged 1 commit into from
Nov 13, 2020

Conversation

calpt
Copy link
Member

@calpt calpt commented Nov 10, 2020

HF pipelines have a check for the type of the passed model. This excludes our ModelWithHeads classes at the moment.

This PR allows this:

model = BertModelWithHeads.from_pretrained("bert-base-uncased")
model.add_qa_head("qa")
pipeline = QuestionAnsweringPipeline(model=model, tokenizer=tokenizer)

@calpt calpt requested a review from hSterz November 10, 2020 11:58
hSterz
hSterz approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@calpt calpt merged commit 4b6383c into adapter-hub:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz