Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: error thrown on recursive delete (fixes #193) #194

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix: error thrown on recursive delete (fixes #193) #194

merged 2 commits into from
Aug 10, 2023

Conversation

taylortom
Copy link
Member

#193

Fix

  • Have amended the delete action to remove the root folder only (the recursive option takes care of the rest).

Testing

Currently only replicable by running an install over an existing install - not sure if this is possible via the CLI.

@taylortom taylortom added the bug label Aug 7, 2023
@taylortom taylortom self-assigned this Aug 7, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@taylortom
Copy link
Member Author

taylortom commented Aug 7, 2023 •
edited
Loading

Just noticed the log here: deleting existing course

Do we want to update this to something more appropriate (less specific)?

@oliverfoster
Copy link
Member

Just noticed the log here: deleting existing course

Do we want to update this to something more appropriate (less specific)?

I'm missing the reason why it would need to change? If you think it should then I'm happy for you to change it.

@taylortom
Copy link
Member Author

Thinking about this again:

  • When running as a CLI you'll only have a single course so that works
  • Running via the AAT uses the framework more abstractly, but also doesn't show the logs

Let's leave the message

@taylortom taylortom mentioned this pull request Aug 7, 2023
Closed
2 tasks
@joe-allen-89 joe-allen-89 merged commit ebc5be6 into master Aug 10, 2023
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/193 branch August 10, 2023 08:30
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
@semantic-release-bot
Chore(release): 3.1.1 [skip ci]
fabeabb 
## [3.1.1](v3.1.0...v3.1.1) (2023-08-10)

### Fix

* error thrown on recursive delete (fixes #193) (#194) ([ebc5be6](ebc5be6)), closes [#193](#193) [#194](#194)
@github-actions
Copy link

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@taylortom taylortom

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylortom @oliverfoster @cahirodoherty-learningpool @joe-allen-89