Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Add feedbackNotFinal optional attribute (fixes #74) #80

Merged
merged 7 commits into from
Oct 17, 2023
Merged

New: Add feedbackNotFinal optional attribute (fixes #74) #80

merged 7 commits into from
Oct 17, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Sep 28, 2023 •
edited by oliverfoster
Loading

Fixes #74

New

  • Adds the feedbackNotFinal optional attribute to each scoring band
  • Updates schemas to include new attribute

Testing

  1. In an Assessment Results component, add feedbackNotFinal attributes to any non-passing scoring band.
  2. Configure the assessment _attempts to "infinite". The "not final" feedback should show with every fail.
  3. Configure the assessment _attempts to a number greater than 1. The "not final" feedback should show with every fail unless attempts have been used up. In that case, the feedback text should appear.
  4. Configure the assessment _attempts to exactly 1. The "not final" feedback should never appear and the feedback text should appear.
  5. feedback should display if feedbackNotFinal is a null string, i.e. feedbackNotFinal is optionally displayed when set

@swashbuck swashbuck self-assigned this Sep 28, 2023
joe-allen-89
joe-allen-89 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 16, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 6fc9595 into master Oct 17, 2023
@oliverfoster oliverfoster deleted the issue/74 branch October 17, 2023 18:19
@github-actions
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Different feedback based on final or not final attempts
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89