Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Clarify the behavior when _assessmentId is left blank (fixes #81) #85

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix: Clarify the behavior when _assessmentId is left blank (fixes #81) #85

merged 3 commits into from
May 29, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented May 15, 2024 •
edited
Loading

Fix #81

Fix

  • Clarifies the behavior when _assessmentId is left blank. The article's assessment ID must also be blank, and this was not made clear in the documentation or schemas.

@swashbuck swashbuck self-assigned this May 15, 2024
@swashbuck swashbuck mentioned this pull request May 15, 2024
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 15, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck mentioned this pull request May 20, 2024
Merged
joe-allen-89
joe-allen-89 reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being very picky, but to be consistent with other help/descriptions just need fullstops.

schema/component.schema.json Outdated Show resolved Hide resolved
properties.schema Outdated Show resolved Hide resolved
swashbuck and others added 2 commits May 29, 2024 08:08
joe-allen-89
joe-allen-89 approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit b27403f into master May 29, 2024
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
Chore(release): 5.2.2 [skip ci]
9985bc0 
## [5.2.2](v5.2.1...v5.2.2) (2024-05-29)

### Fix

* Clarify the behavior when _assessmentId is left blank (fixes #81) (#85) ([b27403f](b27403f)), closes [#81](#81) [#85](#85)
@joe-allen-89 joe-allen-89 deleted the issue/81 branch May 29, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_assessmentId cannot be blank
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89