-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Upgrade MediaElement.js (fixes #298) #299
Open
swashbuck
wants to merge
42
commits into
master
Choose a base branch
from
issue/298
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it no longer exists
swashbuck
changed the title
Breaking: Upgrade MediaElement.js (fixes #298)
Update: Upgrade MediaElement.js (fixes #298)
Aug 15, 2024
swashbuck
changed the title
Update: Upgrade MediaElement.js (fixes #298)
Breaking: Upgrade MediaElement.js (fixes #298)
Aug 15, 2024
…earing when toggleCaptionsButtonWhenOnlyOne: true
… startLanguage to autoplayCaptionLanguage, move startVolume, partially fix mediaCaptionsChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #298
🚧 Work in progress 🚧
Breaking
Notable changes and deletions
speed
,jumpforward
andskipback
have moved to mejs plugins. Other plugins can be considered for inclusion in the future.buildfullscreen()
override ("Overwrite mediaelement-and-player buildfullscreen to remove global delete"). The only significant difference in the current override was to remove twodelete hideTimeout
lines. The newbuildfullscreen()
inmediaelement-and-player.js
does not use this.MediaFeatures
object is now justFeatures
media
,node
, andinstance
. I've added documentation about this toonPlayerReady()
which is the success callback function.mediaElement.player
changed tomediaElement.options
.selectedTrack
has moved to theinstance
object mentioned above.killContextMenuTimer
override to "remove global delete" since it no longer exists in mejsConfiguration changes to existing courses
None
Dependencies
Requires Vanilla theme updates from adaptlearning/adapt-contrib-vanilla#524 Vanilla version TBD.