Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove check for canCycleThroughPagination (fixes #286) #303

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix: remove check for canCycleThroughPagination (fixes #286) #303

merged 2 commits into from
Jun 11, 2024

Conversation

joe-allen-89
Copy link
Contributor

#286

Fix

@joe-allen-89 joe-allen-89 self-assigned this Jun 4, 2024
@joe-allen-89 joe-allen-89 linked an issue Jun 4, 2024 that may be closed by this pull request
_canCycleThroughPagination conflict with narrative controls #286
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks

@kirsty-hames kirsty-hames merged commit d16bd53 into master Jun 11, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/286 branch June 11, 2024 10:26
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
Chore(release): 7.9.1 [skip ci]
05d7f5f 
## [7.9.1](v7.9.0...v7.9.1) (2024-06-11)

### Fix

* remove check for canCycleThroughPagination (fixes #286) (#303) ([d16bd53](d16bd53)), closes [#286](#286) [#303](#303)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_canCycleThroughPagination conflict with narrative controls
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool