have spoor overwrite the hard-coded 'learner info' data with real data #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earner info' data with actual data from the LMS update offline_API_wrapper.js so that it has the student_name in "Lastname, Firstname" (as the SCORM spec requires) and also so that it has student_id/learner_id
oliverfoster
approved these changes
May 2, 2017
Well, in SCORM 1.2 it should always be in that format: |
from 'Student' to 'Surname' following code review
oliverfoster
approved these changes
May 2, 2017
chetan-hajare
approved these changes
May 23, 2017
… object might not be present in _globals
oliverfoster
approved these changes
May 25, 2017
chetan-hajare
approved these changes
May 26, 2017
tomgreenfield
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of adaptlearning/adapt_framework#1040