Skip to content

Commit

Permalink
Resolves #2247, adds a shim to support custom manifest 'identifier' (#…
Browse files Browse the repository at this point in the history
…2332)

Resolves #2247, adds a shim to support custom manifest 'identifier'

This ensures 'adapt_scorm' will be used as a default if the corresponding property is missing.
  • Loading branch information
brian-learningpool authored and moloko committed Jan 22, 2019
1 parent 0e205cf commit db636da
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion grunt/config/replace.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,13 @@ module.exports = function (grunt, options) {
grunt.log.writeln('WARNING: xAPI activityID has not been set');
}
}


// Shim to preserve the 'adapt_scorm' identifier.
if (configJson.hasOwnProperty('_spoor')) {
configJson._spoor._advancedSettings = configJson._spoor._advancedSettings || {};
configJson._spoor._advancedSettings._manifestIdentifier = spoor._advancedSettings._manifestIdentifier || 'adapt_scorm';
}

// Combine the course and config JSON so both can be passed to replace.
return {
'course': filterNullValues(courseJson),
Expand Down

0 comments on commit db636da

Please sign in to comment.