Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent error in Grunt replace task #1021

Closed
brian-learningpool opened this issue Apr 19, 2016 · 1 comment
Closed

Intermittent error in Grunt replace task #1021

brian-learningpool opened this issue Apr 19, 2016 · 1 comment
Assignees
Milestone

Comments

@brian-learningpool
Copy link
Member

Some users have been reporting intermittent errors in the Grunt replace task, such as this one raised against the authoring project:
adaptlearning/adapt_authoring#1132

@brian-learningpool
Copy link
Member Author

After investigation it was discovered that this could be replicated by having undefined or null properties in the config and course objects. (I was able to re-create it on a previous version of a course that used Trickle but didn't have the _completionAttribute defined on config.json).

As the replace is only really required right now by the xAPI and (potentially) Spoor extension, I'm proposing a fix to only allow replacement of a subset of the possible attributes.

brian-learningpool added a commit that referenced this issue Apr 19, 2016
Resolves #1021, passes a subset of attributes to Grunt replace task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant