Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment extension - Hide the feedback button? #1073

Closed
hbaileylxd opened this issue May 23, 2016 · 6 comments
Closed

Assessment extension - Hide the feedback button? #1073

hbaileylxd opened this issue May 23, 2016 · 6 comments
Assignees

Comments

@hbaileylxd
Copy link

In the Authoring Tool even if in Assessment settings I have show feedback set to false all it does is grey out the button.
Can we have it so that the button is not shown, and the Submit/Reset button is shown full width?

Something to do with _canShowFeedback for the component?

@LukaszGrela
Copy link
Contributor

LukaszGrela commented Jun 2, 2016

Yes, this flag could mark component with no-feedback class which then could be used to hide button.

.no-feedback .buttons-feedback {
    display:none;
}

Ofcourse you can do this right now with CSS only, if you want to hide the feedback for particular component just put a style with component id eg.

.c-005 .buttons-feedback {
    display:none;
}

in similar fashion the button.buttons-action needs to be modified to take full width.

I've used this to hide feedback and move submit to right side, still keeping it half width on the assessment page (co-35):

.location-id-co-35 .buttons-feedback {
    display: none;
}

.location-id-co-35 button.buttons-action {
    float: right;
    margin-left: 0.5%;
    margin-right: initial;
}

@hbaileylxd
Copy link
Author

hbaileylxd commented Jun 2, 2016

AH that's excellent Lukasz thank you for the in-depth answer!

I'm using the authoring tool so I went into adapt.less and added this in...

.574f168cacb3084019b1938e .buttons-feedback {
display: none;
}

but it doesn't seem to like it.
so I put .574f168cacb3084019b1938e .buttons-feedback into the class for the component I want it to affect, but still no joy. Any advice?

EDIT - SOLVED

i did the following.....
In my theme's src/theme-extras.lss I added...

.location-id-5735f12cbf106af80e3319ab button.buttons-feedback {
display: none;
}

I took the long ID from the ARTICLE level that the question is in so you would need to switch that out for your article's ID.
Nothing extra needed in the Authoring tool, just this change to theme-extras.less and then a force republish of the course after re-selecting the theme.
To make the submit button full width you just then need to add the following in the same place...

.location-id-5735f12cbf106af80e3319ab button.buttons-action {
width:100%;
}

and so on...

@hbaileylxd
Copy link
Author

The CSS route is probably not ideal. It involves a lot of hand-adding classes to the theme-extras.less and has to be done for every component. I think perhaps more flexibility with the buttons might be useful.

I am wondering if a new component might be a better idea - i'm trying to make one myself but not getting very far! - that offers a choice rather than a marked, feedbacked question.

@paul-mediakitchen
Copy link

paul-mediakitchen commented Jun 10, 2016

Hi Helen

I used the following to hide the feedback button and make the other button 100%

Note I added this in the Style Editor in the Authoring Tool

.assessment .buttons button.buttons-feedback {
display:none;
}

.assessment .buttons .buttons-marking-icon {
position: absolute;
left: 96%;
}

.assessment .buttons button {
width: 100%;
float: left;
}

I also adjusted the position of the tick/cross

@chetan-hajare
Copy link

chetan-hajare commented Jun 28, 2016

issue fixed. PR - adaptlearning/adapt-contrib-vanilla#193

@chetan-hajare
Copy link

Raised 2 PRs: adaptlearning/adapt-contrib-vanilla#194 and #1145

brian-learningpool added a commit that referenced this issue Jul 26, 2016
Resolves #1073, adds support for hiding 'Feedback' button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants