Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

durationLabel property still present in contentObjects.json #1148

Closed
moloko opened this issue Jul 19, 2016 · 2 comments
Closed

durationLabel property still present in contentObjects.json #1148

moloko opened this issue Jul 19, 2016 · 2 comments

Comments

@moloko
Copy link
Contributor

moloko commented Jul 19, 2016

But as far as I can tell this is no longer used following v2.0.3 of contrib-boxmenu... so it should be removed to avoid confusion

@lc-thomasberger
Copy link
Member

+1 to remove if not used.

Can we have value in globals as fallback if not set in contentObjects? If it should be blank set to false in contentObjects or remove from globals.

@moloko
Copy link
Contributor Author

moloko commented Jul 20, 2016

Can we have value in globals as fallback if not set in contentObjects? If it should be blank set to false in contentObjects or remove from globals.

Sorry if I'm misunderstanding but I'm not sure that's relevant here as durationLabel is a label and so should never have been in contentObjects.json in the first place. Note that if durationLabel is not set in course.json the default value from the menu's properties.schema will get used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants