Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-assessment: Suppress marking/feedback until after final attempt #1291

Closed
brian-learningpool opened this issue Oct 19, 2016 · 2 comments

Comments

@brian-learningpool
Copy link
Member

It would be a good enhancement if we had a new option to suppress feedback (marking, model answers) until after the last assessment attempt was completed. Obviously this would only work in cases where there is a finite number of attempts.

This was raised in the forum here:
https://community.adaptlearning.org/mod/forum/discuss.php?d=1554

@sarveshwar-gavhane
Copy link
Contributor

sarveshwar-gavhane commented Dec 12, 2016

oliverfoster pushed a commit that referenced this issue Mar 23, 2017
* Added the ability to 'refresh' a question view at any time i.e. ensure its display is accurate given the component's current state

* Resolving an issue with feedback now being rendered on QuestionView refresh. State is now re-rendered on QuestionView refresh.

* Fixing invalid change to a11y_cntrl usage. Some DRY tidy-up. Reverting accidental whitespace changes

* Model answer button needed to be explicitly enabled before having the 'accessibility' controls disabled. buttonsView refresh was being called with wrong context.

* Changed based on Oliver and Tom's comments:
 - The refresh function in questionView no longer makes use of the 'updateButtons' function in 'questionModel' (which should be used as a 'click event handler'). The 'questionView' itself is now able to determine and set the appropriate button state based on the question state.
 - New button state to represent 'incorrect but no model answer'
 - Duplicate 'updateButtons' call in 'questionModel' refresh has been removed

* Updated old state usages inline with recent move to enum states. 'determineButtonState' is now a separate getter to improve code readability
@moloko
Copy link
Contributor

moloko commented May 15, 2017

@moloko moloko closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants