Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML substitutions are not replaced when building an xAPI course from the Adapt Authoring Tool #1324

Closed
mediabounds opened this issue Nov 18, 2016 · 0 comments

Comments

@mediabounds
Copy link
Contributor

The tincan.xml file in the courses we export from the Adapt Authoring Tool (v0.2.2) with Adapt Framework 2.0.15 do not have the placeholders replaced:

<?xml version="1.0" encoding="utf-8" ?>
<tincan xmlns="http://projecttincan.com/tincan.xsd">
	<activities>
		<activity id="@@config._xapi._activityID" type="http://adlnet.gov/expapi">
			<name>@@course.title</name>
			<description lang="en-US">@@course.description</description>
			<launch lang="en-us">index.html</launch>
		</activity>
	</activities>
</tincan>

After further investigation, we determined that this is actually reproducible when just using the grunt build process for the source code of the course. Running

grunt clean && grunt build

yields a tincan.xml file that looks like the one above. However, executing

grunt build

again successfully replaces the placeholders.

It appears that when the replace task is loaded, it immediately goes and searches for the config JSON file, but that file isn't built yet.

Parsing the config JSON needs to be deferred until the replace task executes.

Pull request coming...

@moloko moloko closed this as completed in 8d7b6ec Nov 23, 2016
moloko added a commit that referenced this issue Nov 23, 2016
…laced

Defers parsing the config JSON until the replace task runs (fixes #1324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant