Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt-contrib-tutor: Add class to indicate which plugin invoked Tutor #1427

Closed
brian-learningpool opened this issue Feb 20, 2017 · 6 comments
Closed

adapt-contrib-tutor: Add class to indicate which plugin invoked Tutor #1427

brian-learningpool opened this issue Feb 20, 2017 · 6 comments
Assignees
@brian-learningpool
Labels
enhancement feature request

Comments

@brian-learningpool
Copy link
Member

Previously some code was added to add specific classes based on the question state, namely correct, incorrect, and partially-correct.

It might be useful to also pass a class through to indicate the component/extension which invoked the Tutor. This would allow more granular control over the layout for theme developers, e.g. if feedback on a Slider should be shown differently to feedback on a MCQ.
@oliverfoster
Copy link
Member

Just an "_id" or something more?

@brian-learningpool
Copy link
Member Author

I was thinking it could maybe add a class composed of the model _type and the _component or _extension attribute, e.g. component-mcq.

@oliverfoster
Copy link
Member

sounds nice. can we do origin id also?

@brian-learningpool
Copy link
Member Author

Yes, this would allow us to tweak styling on specific feedback instances. Good thinking.

@brian-learningpool brian-learningpool self-assigned this Mar 6, 2017
@brian-learningpool
Copy link
Member Author

PR here:
adaptlearning/adapt-contrib-tutor#60

brian-learningpool added a commit that referenced this issue Mar 8, 2017
@brian-learningpool
Added ability to output attributes on Notify
b5b858c 
Specifically this is required to render data-adapt-id as part of #1427.
This was referenced Mar 8, 2017
Merged
Merged
@lc-thomasberger lc-thomasberger mentioned this issue Mar 9, 2017
Merged
brian-learningpool added a commit that referenced this issue Mar 14, 2017
@brian-learningpool
Added ability to output attributes on Notify (#1453)
518b984 
Specifically this is required to render data-adapt-id as part of #1427.
@brian-learningpool
Copy link
Member Author

All outstanding PRs merged.

moloko added a commit to adaptlearning/adapt-contrib-tutor that referenced this issue Jun 24, 2017
@moloko
add dependency on framework 2.0.18 (added by adaptlearning/adapt_fram…
9319b75 
…ework#1427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
enhancement feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brian-learningpool @oliverfoster