Miscellaneous issues with router.js #1458
Assignees
Labels
Comments
brian-learningpool
added a commit
that referenced
this issue
Mar 9, 2017
- arguments were being parsed as args but raw arguments are still passed to functions - The code assumed that only the last argument is may be null, this is not necessarily the case - Plugin routing via the handlePluginRouter function did not appear to reset the _canNavigate property in the same way the handleId function does - Tidied the check on _isCircularNavigationInProgress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's been some time since I've looked at
router.jsbut while trying to develop a plugin which would make use of the plugin routing I noticed a few problems:argumentsbeing parsed asargsbut rawargumentsare still passed to functionsnull, this is not necessarily the casehandlePluginRouterfunction does not appear to reset the_canNavigateproperty in the same way thehandleIdfunction does_isCircularNavigationInProgressis undefined until it's set, the code is going into the block on line 48-51 when it should not beThe text was updated successfully, but these errors were encountered: