Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifyView::closeNotify can be invoked multiple times #1659

Closed
chris-steele opened this issue Jul 13, 2017 · 1 comment
Closed

notifyView::closeNotify can be invoked multiple times #1659

chris-steele opened this issue Jul 13, 2017 · 1 comment
Labels
bug

Comments

@chris-steele
Copy link
Contributor

chris-steele commented Jul 13, 2017 •
edited
Loading

Can be replicated by multiple clicks of close/alert/prompt buttons or multiple escape key presses (in quick succession).

This has the potential to cause serious problems (yep, it did for me in a bespoke Adapt course) given what closeNotify does and the events it triggers (propagating to a11y lib etc). Just need to remove it in same way as drawerView does.
@chris-steele chris-steele changed the title notifyView does not remove keyup handler notifyView::closeNotify can be invoked multiple times Jul 14, 2017
@chris-steele
Copy link
Contributor Author

A general sweep of lingering event handlers (particularly where things are animated) would be worth doing.

jamesrea83 added a commit to jamesrea83/adapt_framework that referenced this issue May 29, 2018
@jamesrea83
adaptlearning#1659 fix to prevent closeNotify being called multiple t…
2e666fa 
…imes
@jamesrea83 jamesrea83 mentioned this issue May 29, 2018
Merged
@jamesrea83 jamesrea83 mentioned this issue Jun 6, 2018
Merged
moloko pushed a commit that referenced this issue Jun 12, 2018
@jamesrea83 @moloko
Issue/#1659 (#2110)
6a0cba8 
* #1659 fix to prevent closeNotify being called multiple times
@moloko moloko closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris-steele @moloko