Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new getInteractionObject() function to questionModel.js #1710

Closed
brian-learningpool opened this issue Aug 10, 2017 · 5 comments
Closed
Assignees

Comments

@brian-learningpool
Copy link
Member

In readiness to support xAPI I'm proposing that a getInteractionObject() is added to QuestionView.js, and implemented in question components the same way as getResponse and getResponseType() currently are.

The purpose of this function is to return an object containing the extra properties which could be appended to an xAPI object.definition object. For example, a choice interaction could return:

{
  choices: [],
  correctResponsesPattern: []
}
@brian-learningpool brian-learningpool self-assigned this Aug 10, 2017
@oliverfoster
Copy link
Member

oliverfoster commented Aug 10, 2017

Please put it on the model. I'll plumb it in to make it backwards compatible for components without models. We really need to move getResponse and getResponseType also

@brian-learningpool
Copy link
Member Author

Sure thing. 👍

@brian-learningpool brian-learningpool changed the title Add new getInteractionObject() function to QuestionView.js Add new getInteractionObject() function to questionModel.js Aug 11, 2017
brian-learningpool added a commit that referenced this issue Aug 11, 2017
Also moved getResponseType() and getResponse() from questionView.js to questionModel.js.
brian-learningpool added a commit that referenced this issue Aug 11, 2017
Also moved getResponseType() and getResponse() from questionView.js to questionModel.js.
@oliverfoster
Copy link
Member

Is this waiting on me? @brian-learningpool

@moloko
Copy link
Contributor

moloko commented Feb 1, 2018

can I close this now that this has been added to the framework? I know we're still waiting on reviews and merges for the changes to the various question components but I think those can be done as and when and shouldn't hold up the v3 framework release

@brian-learningpool
Copy link
Member Author

@moloko, this is ok to close. It would be good to get some eyes on the associated plugin PRs (listed here: #1713) though.

@moloko moloko closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants