Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up of router.js #1757

Closed
brian-learningpool opened this issue Aug 23, 2017 · 0 comments
Closed

Tidy up of router.js #1757

brian-learningpool opened this issue Aug 23, 2017 · 0 comments
Assignees
@brian-learningpool

Comments

@brian-learningpool
Copy link
Member

While having a look at #1752 I noticed that router.js could use a minor tidy up, specifically:

  • code more verbose in places than it has to be
  • calls to console.log()
  • typos in comments
  • inconsistencies in use of quote marks
@brian-learningpool brian-learningpool self-assigned this Aug 23, 2017
brian-learningpool added a commit that referenced this issue Aug 23, 2017
@brian-learningpool
Resolves #1757, minor tidy up of router.js
002362e 
- Replaced console.log() with Adapt.log.warn()
- Removed some duplicated code
- Corrected comment typos
- Fixed inconsistent use of quote marks
- Corrected spacing in curly braces objects for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brian-learningpool