Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On feedback popup open, background content is scrollable. #2154

Closed
NayanKhedkar opened this issue Jul 4, 2018 · 7 comments
Closed

On feedback popup open, background content is scrollable. #2154

NayanKhedkar opened this issue Jul 4, 2018 · 7 comments

Comments

@NayanKhedkar
Copy link
Member

Subject of the issue/enhancement/features

On feedback popup open, background content is scrollable.

Your environment

  • Framework 3.x.x
  • Mobile device(android);

Steps to reproduce

enable _canShowFeedback on any question component.
on answer submitting feedback popup will open try to scroll content using scrollbar(on desktop) and swipe on mobile devices.

Expected behaviour

Background content should not be scrollable when feedback popup opened.

Actual behaviour

on feedback(notify) popup open user can easily scroll background content using scrollbar(on desktop) and swipe on mobile devices.

@oliverfoster
Copy link
Member

I don't think you'll be able to fix the scroll bar on desktop without moving the page into its own scrolling container.
I've been meaning to do this for a while as it will help mitigate ios iframe scrolling issues and help with accessibility virtual cursor placement, but it is a huge change.

@NayanKhedkar
Copy link
Member Author

NayanKhedkar commented Jul 4, 2018

Is it possible to add overflow:hidden to html tag on popup open and remove on popup close.

@oliverfoster
Copy link
Member

oliverfoster commented Jul 5, 2018

Nope, the scroll position will get lost. Seems to work in chrome and ie11... (I'm not sure why I thought it would jump back to the top) although the content will jump to the right because the width of scrollbar goes missing - on browsers with unfloated scrollbars.

@oliverfoster
Copy link
Member

Could you test out #2169? See if that helps?

@NayanKhedkar
Copy link
Member Author

Sure.

@NayanKhedkar
Copy link
Member Author

It fixed the problem. 👍

oliverfoster added a commit that referenced this issue Jul 9, 2018
@moloko
Copy link
Contributor

moloko commented Sep 10, 2018

done in dfabbab

@moloko moloko closed this as completed Sep 10, 2018
jamesrea83 pushed a commit to jamesrea83/adapt_framework that referenced this issue Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants