-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On feedback popup open, background content is scrollable. #2154
Comments
I don't think you'll be able to fix the scroll bar on desktop without moving the page into its own scrolling container. |
Is it possible to add overflow:hidden to html tag on popup open and remove on popup close. |
|
Could you test out #2169? See if that helps? |
Sure. |
It fixed the problem. 👍 |
done in dfabbab |
…g#2155) * issue/adaptlearning#2154 fixed passive event attachment
Subject of the issue/enhancement/features
On feedback popup open, background content is scrollable.
Your environment
Steps to reproduce
enable _canShowFeedback on any question component.
on answer submitting feedback popup will open try to scroll content using scrollbar(on desktop) and swipe on mobile devices.
Expected behaviour
Background content should not be scrollable when feedback popup opened.
Actual behaviour
on feedback(notify) popup open user can easily scroll background content using scrollbar(on desktop) and swipe on mobile devices.
The text was updated successfully, but these errors were encountered: