Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findDescendantModels bug with items _children #2180

Closed
oliverfoster opened this issue Jul 24, 2018 · 1 comment
Closed

findDescendantModels bug with items _children #2180

oliverfoster opened this issue Jul 24, 2018 · 1 comment
Assignees
@oliverfoster
Labels
bug

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jul 24, 2018 •
edited
Loading

Subject of the issue

findDescendantModels is attempting to search components with items models. itemModel doesn't have a getChildren() function compatible with the findDescendantModels function and so an error is thrown.
@oliverfoster oliverfoster self-assigned this Jul 24, 2018
oliverfoster added a commit that referenced this issue Jul 24, 2018
@oliverfoster
issue/#2180 Return if no defined _children type
3d65619
@oliverfoster oliverfoster mentioned this issue Jul 24, 2018
Merged
oliverfoster added a commit that referenced this issue Jul 25, 2018
@oliverfoster
issue/#2180 Refactored findDescendantModels
751e881
oliverfoster added a commit that referenced this issue Jul 25, 2018
@oliverfoster
issue/#2180 Fixed typo
f651f5b
oliverfoster added a commit that referenced this issue Jul 30, 2018
@oliverfoster
issue/#2180 Typos in comments
ad9e0b5
oliverfoster added a commit that referenced this issue Jul 30, 2018
@oliverfoster
issue/#2180 Updated to account for contentObjects
a607f3b
oliverfoster added a commit that referenced this issue Jul 30, 2018
@oliverfoster
issue/#2180 Removed unnecessary comparison
f6c8d56
@moloko
Copy link
Contributor

moloko commented Sep 3, 2018

done in 5a58569

@moloko moloko closed this as completed Sep 3, 2018
jamesrea83 pushed a commit to jamesrea83/adapt_framework that referenced this issue Sep 25, 2018
@oliverfoster @moloko
issue/adaptlearning#2180 Return if no defined _children type (adaptle…
5a58569 
…arning#2181)

* issue/adaptlearning#2180 Return if no defined _children type

* issue/adaptlearning#2180 Refactored findDescendantModels & updated to account for contentObjects

* issue/adaptlearning#2180 Removed unnecessary comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @oliverfoster