Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifyView.js has inconsistent passing of the view (and model) #2279

Closed
brian-learningpool opened this issue Nov 21, 2018 · 0 comments
Closed

notifyView.js has inconsistent passing of the view (and model) #2279

brian-learningpool opened this issue Nov 21, 2018 · 0 comments
Assignees
@brian-learningpool
Labels
enhancement

Comments

@brian-learningpool
Copy link
Member

brian-learningpool commented Nov 21, 2018 •
edited
Loading

The onAlertButtonClicked() function passes through the notifyView (and model) allowing the user to interrogate the model in response to the user's action.

The following events should behave the same:

  • notify:closed
  • notify:cancel
  • The callback triggered from onPromptButtonClicked()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brian-learningpool