Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt-contrib-media: iOS controls #2477

Closed
danielghost opened this issue Jul 15, 2019 · 4 comments
Closed

adapt-contrib-media: iOS controls #2477

danielghost opened this issue Jul 15, 2019 · 4 comments
Labels
bug

Comments

@danielghost
Copy link
Contributor

On iOS, when returning from fullscreen, both the iOS native controls and mediaelement controls are visible. This is most evident when closed captions have been enabled.
@danielghost
Copy link
Contributor Author

This can be worked around by either preventing fullscreen, or using native controls for iOS via the following settings, although this isn't fixing the actual issue:

"_playerOptions": {
    "iPadUseNativeControls": true,
    "iPhoneUseNativeControls": true
}

Previously this option didn't work and threw an error due to the mediaElement.player being undefined, but looks like this must have been resolved in a recent update.

@moloko
Copy link
Contributor

moloko commented Jul 16, 2019

Maybe the answer is to force iPadUseNativeControls and iPhoneUseNativeControls to true whenever the OS is iOS? I wouldn't have a problem with that.

danielghost added a commit to adaptlearning/adapt-contrib-media that referenced this issue Jul 16, 2019
@danielghost
Amends to allow iOS native controls within mediaElement, required for a…
54efe8f 
…daptlearning/adapt_framework#2477.
@danielghost danielghost mentioned this issue Jul 16, 2019
Merged
@danielghost
Copy link
Contributor Author

danielghost commented Jul 16, 2019 •
edited
Loading

Found the issue which was previously present when using these native controls and added a PR to fix.

_startVolume had to be set in the JSON for this to error.

moloko pushed a commit to adaptlearning/adapt-contrib-media that referenced this issue Aug 13, 2019
@danielghost @moloko
Amends to allow iOS native controls within mediaElement, required for a…
0de46a9 
…daptlearning/adapt_framework#2477. (#201)
moloko added a commit that referenced this issue Nov 25, 2019
@moloko
better config for captions, a11y
bf2e258 
enable `toggleCaptionsButtonWhenOnlyOne` as the most typical use-case is only to have one captions language
use native controls on tablet/smartphone to prevent double-display of captions/controls (#2477)
better for a11y to have controls always on-screen
@moloko moloko mentioned this issue Nov 25, 2019
Merged
moloko added a commit that referenced this issue Dec 6, 2019
@moloko
better config for captions, a11y (#2597)
94dfa77 
enable `toggleCaptionsButtonWhenOnlyOne` as the most typical use-case is only to have one captions language
use native controls on tablet/smartphone to prevent double-display of captions/controls (#2477)
better for a11y to have controls always on-screen
@moloko
Copy link
Contributor

moloko commented Dec 11, 2019

I think this should be all OK now @danielghost ?

@moloko moloko closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @danielghost