Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'correct answer' button is not keyboard accessible #2942

Closed
moloko opened this issue Oct 14, 2020 · 4 comments
Closed

'correct answer' button is not keyboard accessible #2942

moloko opened this issue Oct 14, 2020 · 4 comments
Assignees

Comments

@moloko
Copy link
Contributor

moloko commented Oct 14, 2020

Note: I'm specifically referring to navigating the course using the keyboard and NOT when using Jaws etc. Although it would be great if we could also look at getting that working, perhaps using an aria-live region to read out the correct answer(s)?

@moloko
Copy link
Contributor Author

moloko commented Oct 14, 2020

tested using v5.6.1 and v5.7.0 but almost certainly still an issue in v5.7.1

@oliverfoster
Copy link
Member

oliverfoster commented Oct 14, 2020

As detailed previously and unless someone can think of an easier model: each question would need to be able to read its own correct answer as each question has a different format:

multi select mcq: you should have selected options 1, 3 and 5
single select mcq: you should have selected option 1
slider: you should have chosen between 1 and 4

etc

At that point it's almost sensible to make this feedback visible as it is much more useful than what we have at the moment.

@moloko
Copy link
Contributor Author

moloko commented Oct 14, 2020

At that point it's almost sensible to make this feedback visible as it is much more useful than what we have at the moment.

I think if we're talking about reading out the labels (G/MCQ) - which I think you'd need to do as 'option 1' doesn't give you enough context - then it would all start to get a bit crowded on-screen. and unnecessary since you could see the options you should have selected more quickly than reading them out. Matching questions would be even worse. So I think just having them read by the screen reader is a better option.

And yes totally understand it's something each question type will need to implement.

as a short-term solution, is it possible to make the 'correct answer' button keyboard accessible but still keep it hidden from assistive tech?

@oliverfoster
Copy link
Member

as a short-term solution, is it possible to make the 'correct answer' button keyboard accessible but still keep it hidden from assistive tech?

No, tab-index will allow focus regardless of the aria-hidden value. So it'd do nothing when focused / read anyway / mess up the screen reader.

@moloko moloko self-assigned this Jan 28, 2021
moloko added a commit to adaptlearning/adapt-contrib-mcq that referenced this issue Mar 4, 2021
moloko added a commit to adaptlearning/adapt-contrib-gmcq that referenced this issue Mar 4, 2021
moloko added a commit to adaptlearning/adapt-contrib-gmcq that referenced this issue Mar 4, 2021
This reverts commit 6b85388.

Revert " add 'ARIA answer' text for adaptlearning/adapt_framework#2942"

This reverts commit 773c612.
moloko added a commit to adaptlearning/adapt-contrib-gmcq that referenced this issue Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants