Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: Remove strict mode #3017

Closed
oliverfoster opened this issue Jan 14, 2021 · 0 comments · Fixed by #3018
Closed

adapt_framework: Remove strict mode #3017

oliverfoster opened this issue Jan 14, 2021 · 0 comments · Fixed by #3018
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jan 14, 2021

Subject of the issue

Some older code has missing var keywords and so variables are declared on the window namespace.
When switching to the new version of Adapt with rollup, the output is in strict mode changing the way these variables are declared and so breaking some code.

Solution

  1. Update the broken code.
  2. Provide an option to disable strict mode enforcement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant