issue/3017 Added config.json:build.strictMode

[oliverfoster]

fixes #3017

Added

• config.json:build.strictMode to turn on strict mode directives in javascript output
• Turned on in standard course

[moloko]

this will also need to be added to the schema for config.json I think? and also suggest adding it to the 'OOTB' course's config.json

I'm thinking that for FW courses strict mode should be on by default but maybe off by default for AAT ones? purely on the basis that an AAT instance is more likely to have a large collection of 3rd party plugins and it's unreasonable to require an another to amend this setting on every single course they have in the AAT just because one or two of the plugins are missing variable declarations

[oliverfoster]

Yup, sounds like a plan. Need to make sure it fixes the issue before I do that stuff.

[moloko]

@oliverfoster it's certainly fixing the problem of using a 'rollup' build of the FW with spoor v3.3.2 - not seeing any errors now if I set strictMode: false

[oliverfoster]

There isn't any build property in the config schema atm. Is that possible / allowed? @taylortom @tomgreenfield
Should I move it elsewhere?

[oliverfoster]

@moloko it might just be easier to turn off the strict mode universally until some later breaking-change date?

[moloko]

sure, or just default it to off unless enabled via the setting in config.json - I think most people developing plugins do so in the FW first so that would give them the opportunity to get their code working to the strict requirement. I'd still prefer it to be enabled by default for the OOTB course (via config.json)

[moloko]

could we change the name of the setting in config.json to strictMode?

[oliverfoster]

So strict mode is off by default (AAT), enabled with config.json:build.strictMode = true; and enabled in the standard course (FW).

[oliverfoster]

@davetaz :

I can confirm that works and the course builds from the AAT with my broken plugin.

[cahirodoherty-learningpool]

👀