Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLP: odd scrolling behaviour on clicking item #3074

Closed
moloko opened this issue Mar 16, 2021 · 0 comments · Fixed by #3075
Closed

PLP: odd scrolling behaviour on clicking item #3074

moloko opened this issue Mar 16, 2021 · 0 comments · Fixed by #3075
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Mar 16, 2021

Using FW v5.11.0/master, use the PLP to navigate to a component that's outside of the viewport.

Instead of scrolling smoothly to the component, adapt kind-of 'jumps' to a component near it then scrolls the last part.

Suspect issue has been around for a while but only became obvious since we fixed #3022
@moloko moloko self-assigned this Mar 16, 2021
moloko added a commit that referenced this issue Mar 16, 2021
@moloko
fixes for #3074
4572cba
@moloko moloko mentioned this issue Mar 16, 2021
Merged
moloko added a commit that referenced this issue Mar 16, 2021
@moloko
fix for bad PLP scroll (#3075)
087d72f 
* fix for #3074
* return early
@danielghost danielghost mentioned this issue Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes for bad PLP scroll adaptlearning/adapt_framework
1 participant
@moloko