Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt_framework: react components as adapt components #3105

Closed
oliverfoster opened this issue Mar 24, 2021 · 0 comments
Closed

adapt_framework: react components as adapt components #3105

oliverfoster opened this issue Mar 24, 2021 · 0 comments
Assignees

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 24, 2021

Subject of the issue

Allow pure react components as adapt components.

Fixes required to current react implementation:

  1. img loading=eager won't work on nested react class components as these are passed by instance rather than as a set of react virtual dom nodes
  2. should pass props through to the templates, rather than a model and view, as is standard in react, that way the templates can be reused in react native components
  3. eslint is not working properly with react templates
  4. remove unnecessary functions from reactHelpers, find, close and render
  5. rename partials/component.jsx to header.jsx as it can be used for articles and blocks later
  6. add image.jsx to centralise the render of graphics and size switching
  7. add import references to react and react dom where necessary, remove them from the global scope
  8. change view.isReact to view.isJSX as this is more accurate
  9. modify the classes function to remove duplicates
  10. add a prefixClasses function to allow for classes such as __inner and __header to be prefixed with type and component name more easily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants