Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3105-react-fixes various improvements #3140

Merged
merged 9 commits into from
Jun 10, 2021

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented May 10, 2021

first part of #3105

Fixed

  • Passing props through to react templates rather than model, view
  • classes function in reactHelpers.js now removes duplicates
  • img[loading=eager] fix now uses React.createElement rather than template modifications (which didn't work with class based react components)
  • various eslint issues specific to react
  • fixed header.jsx so that it outputs correctly if no value is specified

Changed

  • parials/component.jsx has become header.jsx as it can be used for articles, blocks and pages later
  • Renamed AdaptView.isReact to AdaptView.isJSX as it's more precise

Removed

  • reactHelpers.js clone, find and render functions as unnecessary

Added

  • image.jsx to centralise and perform automatic graphic switching throughout jsx templates
  • reactHelpers.js prefixClasses function, to aid template class creation where component and accordion are prepended to __inner and __widget
  • exposed isInteractive from questionView.js for use in jsx templates

@oliverfoster oliverfoster self-assigned this May 10, 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster
Copy link
Member Author

@tomgreenfield contingent on your review

.eslintrc.json Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@oliverfoster oliverfoster removed the on hold do not merge label Jun 9, 2021
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

@oliverfoster oliverfoster merged commit 208f454 into master Jun 10, 2021
@oliverfoster oliverfoster deleted the issue/3105-react-fixes branch June 10, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants