We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If using https://github.com/adaptlearning/adapt-contrib-languagePicker, it is possible for the size and orientation classes to be incorrect on the html tag once the course has fully loaded/initialized.
adapt-contrib-languagePicker
"_showOnCourseLoad": true
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js doesn't listen to resize orientationchange events until Adapt#app:dataReady, which occurs after the languagePicker, so any changes made before a language selection are redundant and not reflected in the html classes once the data is ready.
resize orientationchange
Adapt#app:dataReady
The most obvious solution would be to change https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js#L19 to listen to configModel:dataLoaded or offlineStorage:ready.
configModel:dataLoaded
offlineStorage:ready
The text was updated successfully, but these errors were encountered:
initialise earlier, fixes #3116
1f69e08
initialise earlier, fixes #3116 (#3120)
2d69674
Successfully merging a pull request may close this issue.
Subject of the issue/enhancement/features
If using https://github.com/adaptlearning/adapt-contrib-languagePicker, it is possible for the size and orientation classes to be incorrect on the html tag once the course has fully loaded/initialized.
Your environment
Steps to reproduce
adapt-contrib-languagePicker
is installed and enabled, with"_showOnCourseLoad": true
Expected behaviour
https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js doesn't listen to
resize orientationchange
events untilAdapt#app:dataReady
, which occurs after the languagePicker, so any changes made before a language selection are redundant and not reflected in the html classes once the data is ready.Proposed change
The most obvious solution would be to change https://github.com/adaptlearning/adapt_framework/blob/master/src/core/js/device.js#L19 to listen to
configModel:dataLoaded
orofflineStorage:ready
.The text was updated successfully, but these errors were encountered: