Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component "left" and "right" layout getting ignored on mobile when JSON does not match order #636

Closed
brian-learningpool opened this issue Jun 22, 2015 · 0 comments
Milestone

Comments

@brian-learningpool
Copy link
Member

This issue was raised on the Adapt Authoring project but I believe it's due to a bug in getChildren() not treating 'left' as the 'first'. There's more information on the original ticket here:
adaptlearning/adapt_authoring#718

brian-learningpool added a commit that referenced this issue Jun 23, 2015
This patch resolves the issue with precedence in that the ordering of the components.json could overide the _layout attribute.  This change assumes that a _layout of "left" should appear first.  In mobile views, if this was not handled in the theme this was not the case.
oliverfoster added a commit that referenced this issue Jun 23, 2015
Resolves #636 - Corrects component _layout attribute issue
@moloko moloko added this to the v2.0.8 milestone Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants